Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayio api 9x #2755

Merged
merged 7 commits into from
Feb 14, 2025
Merged

Displayio api 9x #2755

merged 7 commits into from
Feb 14, 2025

Conversation

FoamyGuy
Copy link
Collaborator

These are the changes needed for changed displayio APIs in CircuitPython 9.0.0.

I have not yet checked any of the learn pages themselves for non-embedded code or references that need updating but I intend to over the coming days.

@FoamyGuy
Copy link
Collaborator Author

I have updated all of the non-github-embedded code in these learn guides now.

I've noticed there are still some github embedds from library examples rather than this repo that still make reference to displayio.FourWire. I believe they all had new / old fallback style code with a note to update them after 9.0 is made stable. I'll go through library examples next and open PRs for the ones that need to change

@FoamyGuy FoamyGuy requested review from TheKitty and a team and removed request for a team and TheKitty March 25, 2024 15:36
@FoamyGuy FoamyGuy marked this pull request as draft March 26, 2024 17:47
@FoamyGuy
Copy link
Collaborator Author

These are currently set with 9.x code only, they are not compatible with 8.x. There is ongoing discussion in discord about the direction to go and timing of this and library code / example updates. Converting this to draft now and potentially have more changes coming

@dhalbert
Copy link
Contributor

dhalbert commented Feb 4, 2025

@FoamyGuy is this ready to finish up?

@FoamyGuy
Copy link
Collaborator Author

FoamyGuy commented Feb 7, 2025

@dhalbert I think so. My understanding is the intention was to do it when we move on from 8.x. I'll make another pass through this repo to see if there are any additional ones in need of updating and commit them here if so. I'll move this out of draft once it's ready.

Copy link
Collaborator

@TheKitty TheKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

@FoamyGuy
Copy link
Collaborator Author

I merged main, and had another pass through this repo. The latest commit changes the remaining usages of 8.x API.

I found A few more learn guide pages with non-embedded code that will need updated:

displayio.i2cdisplay:
https://learn.adafruit.com/gravity-falls-memory-gun/code-the-memory-gun
https://learn.adafruit.com/stepper-motor-turntable/code-the-turntable

display.fourwire:
https://learn.adafruit.com/esp32-s3-ble-ios-media-controller/code-the-media-controller

@FoamyGuy FoamyGuy marked this pull request as ready for review February 14, 2025 21:50
@FoamyGuy FoamyGuy merged commit 18a037d into adafruit:main Feb 14, 2025
4 checks passed
@FoamyGuy
Copy link
Collaborator Author

I will update the guide pages now and make another comment here once it's complete.

@FoamyGuy
Copy link
Collaborator Author

All of these guide pages have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants