-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displayio api 9x #2755
Displayio api 9x #2755
Conversation
I have updated all of the non-github-embedded code in these learn guides now. I've noticed there are still some github embedds from library examples rather than this repo that still make reference to displayio.FourWire. I believe they all had new / old fallback style code with a note to update them after 9.0 is made stable. I'll go through library examples next and open PRs for the ones that need to change |
These are currently set with 9.x code only, they are not compatible with 8.x. There is ongoing discussion in discord about the direction to go and timing of this and library code / example updates. Converting this to draft now and potentially have more changes coming |
@FoamyGuy is this ready to finish up? |
@dhalbert I think so. My understanding is the intention was to do it when we move on from 8.x. I'll make another pass through this repo to see if there are any additional ones in need of updating and commit them here if so. I'll move this out of draft once it's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right
I merged main, and had another pass through this repo. The latest commit changes the remaining usages of 8.x API. I found A few more learn guide pages with non-embedded code that will need updated: displayio.i2cdisplay: display.fourwire: |
I will update the guide pages now and make another comment here once it's complete. |
All of these guide pages have been updated. |
These are the changes needed for changed displayio APIs in CircuitPython 9.0.0.
I have not yet checked any of the learn pages themselves for non-embedded code or references that need updating but I intend to over the coming days.